Move Changeset to use a generic type for the config, to avoid a bunch of boilerplate casting. #15195
+15
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
previously approved these changes
Nov 11, 2024
…f reflection and casting
cgruber
force-pushed
the
chore/cgruber_changeset_generics
branch
from
52b3b29 to
f2c0f5f
Compare
connorwstein
previously approved these changes
Nov 12, 2024
jmank88
reviewed
Nov 12, 2024
patrickhuie19
previously approved these changes
Nov 12, 2024
cgruber
dismissed stale reviews from patrickhuie19, connorwstein, and jmank88
via
a004ca0
Co-authored-by: Jordan Krage <[email protected]>
patrickhuie19
previously approved these changes
Nov 12, 2024
|
Ok - this last commit should undo the need for any change in chainlink-deployments. |
jmank88
approved these changes
Nov 12, 2024
connorwstein
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.